Skip to content

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Nov 5, 2019

This commit changes the topology generator to create a BR dispatcher per BR.
This is required since otherwise non -1 BR will not receive control plane traffic.

Fixes #3318


This change is Reviewable

@lukedirtwalker lukedirtwalker changed the title topo-gen: Create BR dispatcher per PR topo-gen: Create BR dispatcher per BR Nov 5, 2019
Copy link
Contributor

@sustrik sustrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

This commit changes the topology generator to create a BR dispatcher per BR.
This is required since otherwise non -1 BR will not receive control plane traffic.

Fixes scionproto#3318
Copy link
Contributor

@sustrik sustrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker lukedirtwalker merged commit 2741033 into scionproto:master Nov 5, 2019
@lukedirtwalker lukedirtwalker deleted the pubmultidisp branch November 5, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

topology generator: Missing IPs for multiple BRs in a single AS
2 participants