Skip to content

Conversation

sustrik
Copy link
Contributor

@sustrik sustrik commented Nov 6, 2019

This change is Reviewable

Copy link
Contributor

@karampok karampok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 16 of 16 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@karampok karampok closed this Nov 7, 2019
@sustrik sustrik reopened this Nov 7, 2019
@karampok karampok assigned sustrik and unassigned karampok Nov 7, 2019
Copy link
Contributor

@karampok karampok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sustrik)

@sustrik sustrik merged commit d448cc8 into scionproto:master Nov 8, 2019
@sustrik sustrik deleted the move-metrics branch November 11, 2019 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants