Skip to content

Conversation

oncilla
Copy link
Contributor

@oncilla oncilla commented Nov 4, 2019

The unit tests rely on generated trust material. The scion-pki tool
that generates the material is currently under rework and having tests
that require full operability is time consuming during the rewrite.

This change temporarily disables the unit tests to allow faster rework.

Tracking issue #3317


This change is Reviewable

@oncilla oncilla added the c/tooling SCION network tools label Nov 4, 2019
@oncilla oncilla added this to the Q4S2 milestone Nov 4, 2019
@oncilla oncilla requested a review from scrye November 4, 2019 14:22
@oncilla oncilla self-assigned this Nov 4, 2019
Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla)

a discussion (no related file):
Please open an issue mentioning which tests are disabled and why, and that they must be enabled again.

Also include a summary of the minimal requirements that need to be implemented before we can enable them again.

Please reference the issue in this PR.


@oncilla oncilla force-pushed the pub-trust-store-disable-unit-tests branch from d847d72 to 5d94c8a Compare November 5, 2019 09:56
Copy link
Contributor Author

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @scrye)

a discussion (no related file):

Previously, scrye (Sergiu Costea) wrote…

Please open an issue mentioning which tests are disabled and why, and that they must be enabled again.

Also include a summary of the minimal requirements that need to be implemented before we can enable them again.

Please reference the issue in this PR.

Done.


The unit tests rely on generated trust material. The scion-pki tool
that generates the material is currently under rework and having tests
that require full operability is time consuming during the rewrite.

This change temporarily disables the unit tests to allow faster rework.
@oncilla oncilla force-pushed the pub-trust-store-disable-unit-tests branch from 5d94c8a to 238f29a Compare November 5, 2019 11:32
Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@oncilla oncilla merged commit 106b56b into scionproto:master Nov 5, 2019
@oncilla oncilla deleted the pub-trust-store-disable-unit-tests branch November 5, 2019 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/tooling SCION network tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants