Skip to content

Refactor: split pathpol tests into multiple files #3316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2019
Merged

Refactor: split pathpol tests into multiple files #3316

merged 2 commits into from
Nov 5, 2019

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Nov 5, 2019 •
edited by kormat
Loading

Moves ACL tests to act_test.go and sequence tests to sequence_test.go

This change is Reviewable

@lukedirtwalker lukedirtwalker added the refactor Change that focuses around reducing tech debt label Nov 5, 2019
@lukedirtwalker lukedirtwalker requested a review from scrye November 5, 2019 08:56
@lukedirtwalker
Refactoer: split pathpol tests into multiple files
fcf7eed 
Moves ACL tests to `act_test.go` and sequence tests to `sequence_test.go`
@lukedirtwalker
fix lint
aadf9a8
scrye
scrye approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker lukedirtwalker merged commit 3bbc2b2 into scionproto:master Nov 5, 2019
@lukedirtwalker lukedirtwalker deleted the pubPolicyTestMove branch November 5, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@scrye scrye scrye approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
refactor Change that focuses around reducing tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukedirtwalker @scrye