Skip to content

Conversation

sustrik
Copy link
Contributor

@sustrik sustrik commented Oct 29, 2019

This allows to retreive human-readable path representation for
logging and debugging purposes.


This change is Reviewable

@sustrik sustrik requested a review from scrye October 29, 2019 09:13
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @scrye and @sustrik)


go/lib/snet/router.go, line 236 at r1 (raw file):

func (p *path) String() string {
	if p.sciondPath == nil {
		return ""

Should we just print the source here? Similar to the behavior in Destination?

Copy link
Contributor Author

@sustrik sustrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker and @scrye)


go/lib/snet/router.go, line 236 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

Should we just print the source here? Similar to the behavior in Destination?

My understanding is that this is for paths to the local AS. In such case destination=source. However, the path itself is empty, i.e. "".

Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @scrye)

Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @scrye)

@sustrik sustrik removed the request for review from scrye October 29, 2019 09:52
This allows to retreive human-readable path representation for
logging and debugging purposes.
@sustrik sustrik merged commit ab43586 into scionproto:master Oct 29, 2019
@sustrik sustrik deleted the path-stringer branch October 29, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants