Skip to content

metrics: initialize {Counter, Gauge, Histogram} Vec #3283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2019
Merged

metrics: initialize {Counter, Gauge, Histogram} Vec #3283

merged 1 commit into from
Oct 29, 2019

Conversation

karampok
Copy link
Contributor

@karampok karampok commented Oct 28, 2019 •
edited by kormat
Loading

In order to avoid hidden metrics.

Fixes #3265

This change is Reviewable

@karampok karampok force-pushed the pub-init-metrics-vectors branch 2 times, most recently from e390cb8 to cc6f689 Compare October 28, 2019 09:40
@karampok karampok changed the title metric: initialize {Counter,Histogram} Vec metrics: initialize {Counter, Gauge, Histogram} Vec Oct 28, 2019
@karampok karampok force-pushed the pub-init-metrics-vectors branch from cc6f689 to d70b592 Compare October 28, 2019 14:42
@karampok karampok force-pushed the pub-init-metrics-vectors branch from d70b592 to 08c6de5 Compare October 28, 2019 14:43
lukedirtwalker
lukedirtwalker approved these changes Oct 29, 2019
View reviewed changes
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 9 files at r1, 4 of 4 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@karampok karampok merged commit 1205a8a into scionproto:master Oct 29, 2019
@karampok karampok deleted the pub-init-metrics-vectors branch October 29, 2019 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukedirtwalker lukedirtwalker lukedirtwalker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid missing metrics
2 participants
@karampok @lukedirtwalker