Improve messenger metrics #3273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukedirtwalker
requested changes
Oct 24, 2019
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @scrye)
go/protobuf/BUILD.bazel, line 1 at r1 (raw file):
load("@io_bazel_rules_go//go:def.bzl", "go_library")
Remove this 🙈
lukedirtwalker
approved these changes
Oct 24, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @scrye)
lukedirtwalker
approved these changes
Oct 24, 2019
There was a problem hiding this comment.
Reviewable status:
scrye
commented
Oct 24, 2019
There was a problem hiding this comment.
Reviewable status:
go/protobuf/BUILD.bazel, line 1 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
Remove this 🙈
Done.
This adds the following metrics:
```
# HELP lib_infra_messenger_read_sizes_bytes Size of successful reads.
# TYPE lib_infra_messenger_read_sizes_bytes histogram
lib_infra_messenger_read_sizes_bytes_bucket{le="32"} 0
lib_infra_messenger_read_sizes_bytes_bucket{le="64"} 0
lib_infra_messenger_read_sizes_bytes_bucket{le="128"} 3
lib_infra_messenger_read_sizes_bytes_bucket{le="256"} 3
lib_infra_messenger_read_sizes_bytes_bucket{le="512"} 52
lib_infra_messenger_read_sizes_bytes_bucket{le="1024"} 177
lib_infra_messenger_read_sizes_bytes_bucket{le="2048"} 177
lib_infra_messenger_read_sizes_bytes_bucket{le="4096"} 177
lib_infra_messenger_read_sizes_bytes_bucket{le="8192"} 177
lib_infra_messenger_read_sizes_bytes_bucket{le="16384"} 177
lib_infra_messenger_read_sizes_bytes_bucket{le="+Inf"} 177
lib_infra_messenger_read_sizes_bytes_sum 114298
lib_infra_messenger_read_sizes_bytes_count 177
# HELP lib_infra_messenger_reads_total Total number of Read calls.
# TYPE lib_infra_messenger_reads_total counter
lib_infra_messenger_reads_total{result="err_invalid_request"} 26
lib_infra_messenger_reads_total{result="ok_success"} 177
```
Fixes #3187.
# Please enter the commit message for your changes. Lines starting
# with '#' will be kept; you may remove them yourself if you want to.
# An empty message aborts the commit.
#
# Date: Thu Oct 24 10:37:21 2019 +0200
#
# On branch pubpr-fix-3187
# Your branch is up-to-date with 'puborig/pubpr-fix-3187'.
#
# Changes to be committed:
# modified: go/lib/infra/disp/disp.go
# modified: go/lib/infra/disp/disp_test.go
# modified: go/lib/infra/messenger/BUILD.bazel
# modified: go/lib/infra/messenger/adapter.go
# new file: go/lib/infra/messenger/internal/metrics/BUILD.bazel
# new file: go/lib/infra/messenger/internal/metrics/metrics.go
# modified: go/lib/infra/messenger/messenger.go
# modified: go/lib/prom/prom.go
# new file: go/protobuf/BUILD.bazel
#
# Untracked files:
# go/lib/infra/messenger/internal/metrics/metrics_test.go
# msger.metrics
#
lukedirtwalker
approved these changes
Oct 24, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following metrics:
Fixes #3187.
This change is