Skip to content

PS: Add metrics for revocation notifications #3262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 21, 2019
Merged

PS: Add metrics for revocation notifications #3262

merged 4 commits into from
Oct 21, 2019

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Oct 21, 2019 •
edited by kormat
Loading

Adds the following metrics:

# HELP ps_revocations_received_total The amount of revocations received by src type and result
# TYPE ps_revocations_received_total counter
ps_revocations_received_total{result="ok_success",src="notification"} 11

Contributes #3106

This change is Reviewable

@lukedirtwalker lukedirtwalker added PS c/observability Metrics, logging, tracing labels Oct 21, 2019
@lukedirtwalker lukedirtwalker requested a review from scrye October 21, 2019 08:53
scrye
scrye approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker
PS: Add metrics for revocation notifications
3725e1d 
Adds the following metrics:
```
# HELP ps_revocations_received_total The amount of revocations received by src type and result
# TYPE ps_revocations_received_total counter
ps_revocations_received_total{result="ok_success",src="notification"} 11
```

Contributes scionproto#3106
@lukedirtwalker
wip
cdbf1fa
@lukedirtwalker
fix lint
e3c4028
@lukedirtwalker
Revert "wip"
c216362 
This reverts commit 4232a45.
@lukedirtwalker lukedirtwalker merged commit 8ee1b1c into scionproto:master Oct 21, 2019
@lukedirtwalker lukedirtwalker deleted the pubPSMetricsRevoc branch October 21, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@scrye scrye scrye approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c/observability Metrics, logging, tracing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukedirtwalker @scrye