Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @oncilla)

go/lib/scrypto/asym.go, line 82 at r1 (raw file):

		var privKeyFixed, pubKey [32]byte
		copy(privKeyFixed[:], privKey)
		curve25519.ScalarBaseMult(&pubKey, &privKeyFixed)

Is the endianness here correct when these values are loaded from files? I think we use little endian everywhere, but just want to double check it with you.

go/tools/scion-pki/internal/v2/keys/pub.go, line 61 at r1 (raw file):

				return nil, serrors.WrapStr("unable to load private keys for AS", err, "ia", ia)
			}
			if len(keys) > 0 {

Can drop the if, default val is nil if there are no keys.

go/tools/scion-pki/internal/v2/keys/pub.go, line 91 at r1 (raw file):

		var keys []keyconf.Key
		for _, privKey := range privKeys {
			key := privKey

This shallow copy is dangerous; if key.Bytes mutates prior to the assignment below, privKey.Bytes is also affected. I think implementing a proper Copy is safer (it also signals to someone reading the code that everything is safe; right now, I needed to go within keyconf.Key to reason what is copied by reference/pointer, and what is copied by value).

go/tools/scion-pki/internal/v2/keys/pub.go, line 131 at r1 (raw file):

		return keyconf.Key{}, serrors.WrapStr("unable to read file", err)
	}
	block, _ := pem.Decode(raw)

keyconf.KeyFromPEM would panic on block == nil, but that can be returned by pem.Decode if the input is garbage.

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @scrye)

go/lib/scrypto/asym.go, line 82 at r1 (raw file):

It is, yes.
But it is a bit awkward, I agree.

go/tools/scion-pki/internal/v2/keys/pub.go, line 61 at r1 (raw file):

True, but I wanted to avoid creating superfluous directories.

go/tools/scion-pki/internal/v2/keys/pub.go, line 91 at r1 (raw file):

Done.

go/tools/scion-pki/internal/v2/keys/pub.go, line 131 at r1 (raw file):

Good catch!

Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved