Skip to content

Conversation

karampok
Copy link
Contributor

@karampok karampok commented Sep 25, 2019

In order to expose in metrics the result ok_new or ok_update when we have received a beacon,
the insert function to the db must return back this information.

Contributes #3104


This change is Reviewable

@karampok karampok requested a review from oncilla September 25, 2019 13:06
@karampok karampok force-pushed the pub-bs-expose-db-stats branch from d3f097e to 00c7604 Compare September 25, 2019 13:41
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@karampok karampok force-pushed the pub-bs-expose-db-stats branch from 00c7604 to 6772cd9 Compare September 26, 2019 11:13
@karampok karampok merged commit 5c8fa4f into scionproto:master Sep 26, 2019
@karampok karampok deleted the pub-bs-expose-db-stats branch September 26, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants