Skip to content

discovery: Call correct callback when cleaning dynamic #3189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2019
Merged

discovery: Call correct callback when cleaning dynamic #3189

merged 1 commit into from
Sep 26, 2019

Conversation

oncilla
Copy link
Contributor

@oncilla oncilla commented Sep 26, 2019 •
edited by kormat
Loading

This change is Reviewable

@oncilla oncilla added the bug Something isn't working label Sep 26, 2019
karampok
karampok approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@karampok karampok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@oncilla oncilla merged commit 032406f into scionproto:master Sep 26, 2019
@oncilla oncilla deleted the pub-fix-discovery branch September 3, 2020 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@karampok karampok karampok approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@karampok karampok

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oncilla @karampok