Skip to content

Conversation

scrye
Copy link
Contributor

@scrye scrye commented Sep 24, 2019

This change is Reviewable

@scrye scrye added the refactor Change that focuses around reducing tech debt label Sep 24, 2019
@scrye scrye requested a review from oncilla September 24, 2019 11:52
@scrye scrye self-assigned this Sep 24, 2019
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 29 of 29 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@scrye scrye merged commit fa83f84 into scionproto:master Sep 24, 2019
@scrye scrye deleted the pubpr-remove-goconvey-configs branch September 24, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Change that focuses around reducing tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants