Reviewed 34 of 34 files at r1.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @oncilla)

a discussion (no related file):
I think this is a partly breaking change. I would add the breaking change label. Also not in the desription that metrics will be renamed, optimally with a list of old namespace -> new_namespace.

go/cert_srv/internal/metrics/metrics.go, line 18 at r1 (raw file):

n

Also make it public?

go/godispatcher/internal/metrics/metrics.go, line 26 at r1 (raw file):

dispatcher

maybe disp?

go/lib/prom/prom.go, line 77 at r1 (raw file):

// Note this should be called before any other interaction with prometheus.
// See also: https://github.com/prometheus/client_golang/issues/515
func UseDefaultRegWithElem(elemId string) {

Why is that still here?

go/sciond/internal/metrics/metrics.go, line 18 at r1 (raw file):

sciond

sd ?

Reviewable status: 20 of 36 files reviewed, 5 unresolved discussions (waiting on @lukedirtwalker and @oncilla)

go/godispatcher/internal/metrics/metrics.go, line 26 at r1 (raw file):

Done.

go/lib/prom/prom.go, line 77 at r1 (raw file):

Forgot to remove.
Done.

go/sciond/internal/metrics/metrics.go, line 18 at r1 (raw file):

Done.

Reviewable status: 20 of 36 files reviewed, 5 unresolved discussions (waiting on @lukedirtwalker and @oncilla)

a discussion (no related file):

done

Reviewable status: 20 of 36 files reviewed, 5 unresolved discussions (waiting on @lukedirtwalker)

go/cert_srv/internal/metrics/metrics.go, line 18 at r1 (raw file):

Done.

Reviewed 16 of 16 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved