mock: Generate mocks for matched packages #3150
Conversation
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla)
Makefile, line 42 at r1 (raw file):
PKG_MATCHER
I would probably name the env variable MOCKS or MOCKS_PKGS. PKG_MATCHER doesn't really make sense in a global context.
Also couldn't you use env_name in add_argument below, so you wouldn't need to change the make file? But then maybe the env name can be less global again :man-shrugging:
This changes allows generating the mock files for specific packages. Sample usage: `make PKG_MATCHER=svc mocks` generates only packages that contain `svc` in the import path.
8628ba9 to
347f94d
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
Makefile, line 42 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
PKG_MATCHERI would probably name the env variable
MOCKSorMOCKS_PKGS.PKG_MATCHERdoesn't really make sense in a global context.
Also couldn't you useenv_nameinadd_argumentbelow, so you wouldn't need to change the make file? But then maybe the env name can be less global again :man-shrugging:
Done.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
This changes allows generating the mock files for specific packages.
Sample usage:
PKG_MATCHER=svc make mocksgenerates only packages that contain
svcin the import path.This change is