Skip to content

BK: Add automatic retry for jobs that lost their agent #3156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2019
Merged

BK: Add automatic retry for jobs that lost their agent #3156

merged 2 commits into from
Sep 17, 2019

Conversation

worxli
Copy link
Contributor

@worxli worxli commented Sep 17, 2019 •
edited
Loading

Jobs where the agent is lost are not automatically retried, see buildkite/docs#355. And docs: https://buildkite.com/docs/pipelines/command-step#automatic-retry-attributes

This change is Reviewable

@worxli worxli requested review from kormat and Hermain September 17, 2019 13:03
Hermain
Hermain approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@Hermain Hermain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @kormat)

@worxli worxli removed the request for review from kormat September 17, 2019 15:16
@worxli worxli merged commit fba6b8c into scionproto:master Sep 17, 2019
@worxli worxli deleted the buildkite-retry branch September 17, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Hermain Hermain Hermain approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@worxli @Hermain