Skip to content

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Sep 16, 2019

Previously app_builder was built as a dependency of the dispatcher docker image, this is no longer the case, therefore we need to explicitly pull it to be able to build the tester image.

Also remove old unused docker files.

This change is Reviewable

@lukedirtwalker lukedirtwalker changed the title Try to fix CI CI: Fix build by making app_builder dependency explicit Sep 16, 2019
@lukedirtwalker lukedirtwalker marked this pull request as ready for review September 16, 2019 15:32
Copy link
Contributor

@kormat kormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker lukedirtwalker merged commit 65ea66f into scionproto:master Sep 16, 2019
@lukedirtwalker lukedirtwalker deleted the pubFixCI branch September 16, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants