Skip to content

jaeger: Fix storing segments #3131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2019
Merged

jaeger: Fix storing segments #3131

merged 1 commit into from
Sep 10, 2019

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Sep 10, 2019 •
edited by kormat
Loading

In #3128 we switched to temp storage, but that is deleted after calling down on the container.
That would mean on CI we can't access the traces, therefore switch back to the old storage approach.

Also update the version in scion.sh

This change is Reviewable

@lukedirtwalker
jaeger: Fix storing segments
b875be2 
In scionproto#3128 we switched to temp storage, but that is deleted after calling down on the container.
That would mean on CI we can't access the traces, therefore switch back to the old storage approach.

Also update the version in scion.sh
@lukedirtwalker lukedirtwalker added the feature New feature or request label Sep 10, 2019
oncilla
oncilla approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

oncilla
oncilla approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker lukedirtwalker merged commit 2f7ddaa into scionproto:master Sep 10, 2019
@lukedirtwalker lukedirtwalker deleted the pubJaegerFix branch September 10, 2019 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oncilla oncilla oncilla approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukedirtwalker @oncilla