Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @oncilla)

go/tools/scion-pki/internal/v2/trcs/combine.go, line 67 at r1 (raw file):

}

func loadUniqueSignatures(isd addr.ISD, ver scrypto.Version, encoded trc.Encoded) (

uff, I think line splits like this are weird to me. I would split it after the version argument.

go/tools/scion-pki/internal/v2/trcs/util.go, line 61 at r1 (raw file):

		return common.NewBasicError("unable to marshal signed TRC", err)
	}
	if err := validateResult(raw); err != nil {

Why do we need to Marshal it to json just UnMarshal it again for validation? couldn't we do validation on the signed argument? And only if it succeeds do the marshalling?

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)

go/tools/scion-pki/internal/v2/trcs/combine.go, line 67 at r1 (raw file):

Done.

go/tools/scion-pki/internal/v2/trcs/util.go, line 61 at r1 (raw file):

This ensures that what we write is actually parsable and verifiable.
If we just verify the parsed version, we cannot guarantee that.
Should also not really be a performance concern, since manual TRC generation is infrequent anyway.

Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved