Reviewed 9 of 9 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @oncilla)

go/tools/scion-pki/internal/tmpl/topo.go, line 139 at r1 (raw file):

		m[ia.I] = struct{}{}
	}
	var isds []addr.ISD

Why does this function return a slice, when the return value is just used to iterate over?

go/tools/scion-pki/internal/v2/tmpl/topo.go, line 122 at r1 (raw file):

}

// topoFile is used to parse the topology description.

We should probably have this in a shared library somewhere at some point. (certainly not for this PR)

go/tools/scion-pki/internal/v2/tmpl/topo.go, line 132 at r1 (raw file):

		m[ia.I] = struct{}{}
	}
	var isds []addr.ISD

ditto

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @lukedirtwalker)

go/tools/scion-pki/internal/tmpl/topo.go, line 139 at r1 (raw file):

Done.

go/tools/scion-pki/internal/v2/tmpl/topo.go, line 122 at r1 (raw file):

Sure. If/when we write the generator in go.

go/tools/scion-pki/internal/v2/tmpl/topo.go, line 132 at r1 (raw file):

Done.

Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved