Disp: Do not allow running as root #3074
Conversation
3026f84 to
48f8fa8
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @karampok)
go/godispatcher/main.go, line 166 at r1 (raw file):
func checkPerms() error { user, err := user.Current()
Varname shadows package name; use a different identifier instead (just u works here, because the function is very small).
48f8fa8 to
e20c9ff
Compare
Modify also BR/SIG to avoid package shadowing Fixes scionproto#3067
e20c9ff to
394f566
Compare
There was a problem hiding this comment.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @karampok and @scrye)
go/godispatcher/main.go, line 166 at r1 (raw file):
Previously, scrye (Sergiu Costea) wrote…
Varname shadows package name; use a different identifier instead (just
uworks here, because the function is very small).
Done.
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Fixes #3067
This change is