BR: improve control error messages #3029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c10d1dc to
b302ed2
Compare
oncilla
approved these changes
Aug 22, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
go/border/rctrl/ifstate.go, line 77 at r1 (raw file):
dst.NextHop = addr if _, err := snetConn.WriteToSCION(pld, dst); err != nil { retErr = common.NewBasicError("Writing IFStateReq", retErr, "dst", dst, "err", err)
With this, error logs are lost.
b302ed2 to
15b0e38
Compare
oncilla
approved these changes
Aug 26, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:
15b0e38 to
1108ce3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is