SIG: Tighten the API between main and ingress/egress #3018
Conversation
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @sustrik)
go/sig/egress/api.go, line 36 at r1 (raw file):
fatal.Check() // Ringbuf for unused packets. iface.EgressFreePkts = ringbuf.New(iface.EgressFreePktsCap, func() interface{} {
Why not call iface.Init instead?
go/sig/egress/api.go, line 46 at r1 (raw file):
} func ReloadConfig(cfg *config.Cfg) bool {
This is never called and can be removed.
Ingress API is reduced to 1 function: * ingress.Init() Egress API is reduced to 2 functions: * egress.Init() * egress.ReloadConfig()
There was a problem hiding this comment.
Reviewable status: 2 of 6 files reviewed, 2 unresolved discussions (waiting on @scrye)
go/sig/egress/api.go, line 36 at r1 (raw file):
Previously, scrye (Sergiu Costea) wrote…
Why not call
iface.Initinstead?
Done.
go/sig/egress/api.go, line 46 at r1 (raw file):
Previously, scrye (Sergiu Costea) wrote…
This is never called and can be removed.
It's called from main.go:198
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
go/sig/egress/api.go, line 46 at r1 (raw file):
Previously, sustrik (Martin Sustrik) wrote…
It's called from main.go:198
It didn't use to be 😄
Ingress API is reduced to 1 function:
Egress API is reduced to 2 functions:
This change is