Skip to content

Conversation

jiceathome
Copy link
Contributor

@jiceathome jiceathome commented Jul 27, 2023

Update instructions to include Fedora as a supported platfom and to link to the most relevant instructions on the docker site.


This change is Reviewable

Update instructions to include Fedora as a supported platfom and to link to the most relevant instructions on the docker site.
Copy link
Contributor

@matzf matzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jiceatscion)


doc/dev/setup.rst line 10 at r1 (raw file):

#. Make sure that you are using a clean and recently updated linux distribution. Distributions that are
   nown to work are:

Suggestion:

known

doc/dev/setup.rst line 12 at r1 (raw file):

   nown to work are:

   * **Ubuntu** release 18 or later.

Nit: "18.04" . Ubuntu version numbers are "year.month". AFAIU there is no particular commonality between the two releases in the same year.

Ubuntu complete version number.
Typoe.
Copy link
Contributor Author

@jiceathome jiceathome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @matzf)


doc/dev/setup.rst line 10 at r1 (raw file):

#. Make sure that you are using a clean and recently updated linux distribution. Distributions that are
   nown to work are:

Done.


doc/dev/setup.rst line 12 at r1 (raw file):

Previously, matzf (Matthias Frei) wrote…

Nit: "18.04" . Ubuntu version numbers are "year.month". AFAIU there is no particular commonality between the two releases in the same year.

done

Copy link
Contributor

@matzf matzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jiceatscion)

@matzf matzf merged commit 2ce7932 into scionproto:master Jul 31, 2023
@jiceathome jiceathome deleted the patch-1 branch August 29, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants