topology: deprecate unused attributes #4333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72e4c0f to
fbf5062
Compare
oncilla
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Reviewed 21 of 21 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @matzf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate unused attributes
authoritative,votingandissuingfrom the topology.json configuration. These are no longer considered by any service or tool and the functionality has been moved into the cs.toml (containing a[ca]section for "issuing" ASes) or into the TRC and the configuration of the corresponding tooling.Only the
coreattribute option remains. In the long run, this should either disappear entirely from the topology configuration or be changed to a boolean flag.In the internal
private/topology, remove the unusedCA() boolfrom the interface, and simplify the representation of the state from a list of attributes to a simplerIsCore.The goal here is mainly to avoid confusion caused by the unused attributes.
This change is