Skip to content

Conversation

DanCardin
Copy link
Contributor

Fixes #102

Essentially, branched iteration order is arbitrary, we happen to choose a path (which is the path rendered by alembic history), but the "current" revision at each stop point is ambiguous. So instead, we need to keep track of the source and dest revisions at each stop point and supply that as the "current" revision.

This is only meaningful for the built-in "up_down_consistency" test, because it's the only one that upgrades each revision individually.

@DanCardin DanCardin force-pushed the dc/ensure-branched-trace branch from 3a7f7d2 to 908f252 Compare March 27, 2024 15:36
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8454501712

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 94.239%

Files with Coverage Reduction New Missed Lines %
src/pytest_alembic/runner.py 2 94.61%
Totals Coverage Status
Change from base Build 8435910484: -0.3%
Covered Lines: 836
Relevant Lines: 879

💛 - Coveralls

@DanCardin DanCardin force-pushed the dc/ensure-branched-trace branch from 63cb234 to 853b116 Compare August 30, 2024 12:45
@DanCardin DanCardin force-pushed the dc/ensure-branched-trace branch 6 times, most recently from fa58197 to 6a5a4f8 Compare August 30, 2024 14:12
@DanCardin DanCardin force-pushed the dc/ensure-branched-trace branch from 6a5a4f8 to 0c32cb2 Compare August 30, 2024 14:26
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10634391854

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on dc/ensure-branched-trace at 94.2%

Totals Coverage Status
Change from base Build 10454491203: 94.2%
Covered Lines: 837
Relevant Lines: 880

💛 - Coveralls

@DanCardin DanCardin merged commit 5ff6ca0 into main Aug 30, 2024
76 checks passed
@DanCardin DanCardin deleted the dc/ensure-branched-trace branch August 30, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated migration application
2 participants