Skip to content

Prepare release v2.1.0 #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Apr 29, 2022
Merged

Prepare release v2.1.0 #399

merged 23 commits into from
Apr 29, 2022

Conversation

HJZollner
Copy link
Collaborator

Update master to current develop version to prepare release.

HJZollner and others added 23 commits March 23, 2022 18:22
Updated io_writeniimrs to work with more general input data. This should now manage any 7D SVS data that uses Matlab MRS structure.

Fixed error in main loop of NIFTI write routine, and added a temporary seq label for NFITI data.

Fixed error in osp_processHERCULES concatenation of ref averages
Rename metabolite models for consistency:
Scyllo -> sI
Ins -> mI
Updated in basis sets, plot routines, example scripts, libraries, GUI text, and main functions.
This work has been supported by NIH grants R01 EB016089, P41 EB15909, P41 EB031771, R01 EB023963, and K99 AG062230.
- Bug fix for single average HERMES/HERCULES Siemens data
- Feature request: Update Twix loader to accept combined fMRI/fMRS sequence
GUI related bug fixes:
- nExperiments correctly initialized
- raw size correctly initialized
- metabolite names correctly initialized
- SPM12 crash in MATLAB R2021 and newer
- residual amplitude correctly stored
- Adapted struct output according to new QM measures
Some plot lines in osp_plotLoad and osp_plotProcess did not specify the real part of spectra to be plotted, so the obligatory "Warning: Imaginary parts ignored" would pop up. This commit fixes this behavior.
Added voxel coregistration for Nii MRS. Currently working for Philips data but not Siemens. Main changes:

Added coreg_nifti.m which uses nii_tool to coregister voxel to structural.
Added nii_xform to lib - function used by nii_tool
updated OspreyCoreg to handle NIFTI
Modified osp_fitinitialise to throw warning if sequence type not detected
Modified osp_LoadNii to try and populate vendor/seq fields of MRSCont
Fixed bug in osp_plotSegment
Intercept and skip read errors during Siemens DICOM header parsing. Add missing flag indicating whether multi-file IMA data have been averaged on-scanner. Fix an error resulting from an unknown `seq` variable. Fixes #395
Empty protocol name handling for NIfTI MRS, and bug fix in osp_combineCoils
Integrate NIfTI MRS read/write/coreg implementaion
Fix RDA writing error (data points were not ordered correctly).
Fixes TWIX coil combination procedure in case no water reference is provided.
@HJZollner HJZollner merged commit 998aeda into master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants