-
Notifications
You must be signed in to change notification settings - Fork 44
lcmodel-integration #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lcmodel-integration #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
HJZollner
commented
Aug 26, 2021
- Add LCModel integration for unedited data into the master branch
- Add NIFTI MRS data loader and export
- Prepare dw-MRS
A large commit containing the first batch of changes to accommodate LCModel fitting. This includes updates to the control file writing, re-import of the modeling results, and visualization. For now, these functions only work with un-edited data. Visualization works for the PDF output, but not for the GUI yet.
Added azure pipeline success batch to README.md [ci skip]
Adding scripts to de-identify Philips SPAR, GE P, and Siemens TWIX files.
- removed redundant basis sets from MRS container and updated all functions that need those - Osprey GUI figure is now overwritten when a new instance is started - Bug fix related to potential naming issue for the sub-spectra alignment as defined in the example jobFiles
Memory Optimization
- Added new functionalities which allow to share/copy the MRS container between different machines without losing the GUI functionalities. This flag is turned of by default to reduce the file size of the container, but it can be run on already processed containers. - OspreyAddImages stores the three plane images that are required for the plot functions of coreg and seg into the container. - osp_extract_three_plane_image.m adds the images for the OspreCoreg plot into the container - osp_extract_three_plane_image_seg.m adds the images for the OspreSeg plot into the container - Further updates were added to the OspreyGUI function which automatically checks whether the container has been moved. The LogFile is then recreated on the new machine and the Coreg/Seg buttons are disabled. The coreg/seg tab is activated only for containers where the image files are available or the results are stored in the container. The same is the case for the external nii viewer.
Decouple MRS container from local machine
This update introduces new functions for loading and writing NIfTI-MRS data, tweaks existing ones to ensure compatibility, and adds example data. At this point, only conventional (non-dynamic) single-voxel data has been tested. Support for spectral editing, MRSI etc. will follow.
- Bug fix wrt reported issues with the GUI being closed during module calls. This was due to the changes of the handle visibility of the GUI which was supposed to overwrite old instance upon GUI call. The handle visibility is now changed dynamically on button click events to avoid crashes.
BugFix accidental GUI crash
New functions to provide, read and write custom LCModel control files.
- updated downstream modules to work with lcmodel - updated GUI to work with lcmodel
- removed metabolite combinations from stack plot - ensured full GUI functionality - automated platform check and font picker
Adding an if-statement to intercept cases where no basis set was formally specified in the job file (for use with special LCModel-sptype-settings like lipid-8, which don't require a basis set).
When data from the JHU Universal Sequence (Siemens) is loaded, io_loadspec_twix automatically sorts the sub-experiments for MEGA/HERMES into FID-A sub-spectra. This behaviour crashed data that was collected with less transients than expected sub-spectra. This is now fixed. Similarly, op_averaging demolished the dimension arrangements when it encountered single-transient data. This is now fixed, too.
- added platform extraction to check for LCM binaries - updated ver number for release - avoided accidental nii removal
Added win_10 LCModel binaries
-Added macos catalina LCModel binaries
Load nii mrs
Lcmodel integration
-Updated the example jobFiles to include NII MRS and LCModel fitting
Update example jobFiles
Update Nii flag to default settings
Update OspreySettings
- Fix bug related to fit plots of Osprey Model
Fix plot related issues
- removed some bugs with regards to plotFit and plotModule - OspreySeg bug WRT to gz files removed
lcm-integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.