-
Notifications
You must be signed in to change notification settings - Fork 44
Release 1.0.2 preparation #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Added MRSI mask for fitting - New visualization for MRSI data for processed and fitted data - data/list loading for arbitrary average numbers
MRSI update
- fixed MoCo bug related to the MRSi implementation where the phase between on and off is 180 degree - added fitting of water data for MRSI
Fix MoCo and add water fit
- updated PE-edited MP basis sets (added EA basis function) - delete Philips 40 ms unedited basis sets which was not stored in the right folder - added Philips 80 and 140 ms unedited basis sets
Update basis sets
- Removed H2O from the default metabolite list, so that it is not included in the metabolite fit anymore. It can still be included if the user specifies H2O in his metabolite list manually. - The water basis function is loaded from the specific basis set if it is needed for the fit of the water scan. This happens regardless of the metabolite list the user specifies.
Update_water_fit
-adding bet for masking -updating quantify MRSI to allow metabolite maps from different sub-spectra
MRSI_update
-Apparently the index of the number kx and ky lines have changed in R 5.7.1
MRSI_data_list_update
- Include a water ref normalization
Update plot_MRSi_proc
- Added flags to control the thresholds and region for the MoCo script - Added flags to control the subspectra alignment - Added a zero line and more infos to the MRSIprocess plot - Added the option to plot the uncorrected data to the processed view - Added processing of the data that is not motion corrected (this still needs a flag to be deactivated later) - Fixed segmentation
Added a new Osprey module OspreyMinReport.m that creates a markdown table including the minimum parameters for reporting of MRS studies (defined in MRSinMRS). This includes the following changes to other functions: - Extracting software versions during the loading process (io_loadspec_sdat, io_loadspec_twix, and io_loadspec_GE) - Automatic generation of md report during OspreyOverview call
Initial_commit_MRSinMRS_markdown
- Bug fix related to vendor-specific naming conventions in the voxel geometry - Minor layout changes
Update OspreyMinReport
- Updated the calculation of the fit quality parameter to match the original paper Barros & Slotboom. The quality is defined as a variance ratio between residual in the fitted region and noise
Update osp_fit_Quality
-Added a decision tree, that creates a metabolite list for the preliminary reduced fit according to the input list of the user (e.g. if the user performs a phantom scan with fCho instead of GPC or PCh in the list) this metabolite is picked instead of the default (NAA, Cr, PCh, Glu, and Ins.
Updated prelim fit
Fixes reported Bug in the correlation plot within the GUI where it was not possible to switch between external variables
Fix GUI bug
-Updated functionalities for multi slice MRSI data
Multi-slice-MRSI
This file doesn't belong here.
Add a different route to retrieve the FID from Siemens DICOM files.
Update GELoad.m
Updating loader for 3 slice MRSI data
Updates for 3 slice MRSI
- aded HERMES/HERCULES to the MRSinMRS report function -updated the Siemens HERCULES I basis set to have a correct MM09 in the diff1 spectrum
MRSI & HERCULES updates
- added MM3co model to the conc model - updated the basis set for HERCULES I Siemens
HERCULES updates II
Some updates based on the Jim's feedback: - 40 ms unedited Siemens basis set - VE11 leftshift bug fixed - OspreyOverview can be performed on data that is not modeled to generate scaled spectra and mean plots in the OverviewTab
Jim's Feedback Update #1
Changed the control file to defaults settings and added the LCModel freeware key.
Jim's Feedback Update #2
One addtional change to match teh LCM default
Jim's Feedback Update #3
Fix GE-DICOM-based voxel coregistration.
Saving some space by creating a generic function checking that all modules required to run a particular module have been executed. Also some small clean-ups here and there. Renaming folder 'utilites' to 'utilities'.
- Changed the default model for modeling metabolite-nulled data. The reference shift is estimated from the MM data now, while FWHM estimates are still taken from the metabolite data. This model performs better than the older version (fund empirically)
Update MM modeling
- Fixes bug related to not being able to create overview spectra from the metabolite nulled data
Bug fix MM overview
- Updated example jobFiles to follow BIDS structure for automated generation. - Examples for a direct path to the data are also included - The version check is only giving a soft warning and is not stopping the GUI from working - Renamed the Gauss fixed model to reflect the paper naming - Updates to the jobFiles to reflect the most recent changes (e.g. no HERCULES1/2 and new metabolites as editing targets) -added new Version number for release v.1.0.2
Update exmples jobFiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging latest develop into the master branch