Finalizing osp_exportParams #598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ortParams Resetting the repo.
…b file examples, and put the function call at the end of OspreyOverview.
…b file examples, and put the function call at the end of OspreyOverview.
- Added all possible naming combinations for Osprey legacy code
|
Hi @JohnLaMaster, That looks great! Thanks for integrating this so nicely. I have added all possible naming combinations of the fit struct to the auxiliary function ( I think you asked for them in the last pull request). These will only appear in older Osprey versions or in the MRSI branch. Best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osp_exportParams now also returns all of the info from the QM table, in a nicer, automated fashion. Based on the order of function calls in RunOspreyJob, I added the export call to the end of OsperyOverview so that everything will be done regarding the fit before exporting. I added the relevant code to OspreyJob.m and the example job*.m files under exampledata. It should now be able to run seamlessly.
There are two parts to the opts variable as follows:
opts.exportParams.flag = 1; % Options: 0 (no, default), 1 (yes) opts.exportParams.path = '/path/to/save/'; % String to save directoryActual content changes in the job files occurs around lines 145-150.
Unless something in the possible_keys list needs updating or additional variables need to be exported, this should be one of the last pull requests.