Exporting fitting parameters #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I work on the code for my project that uses osp_exportParams, I came across two things that I'm missing so far. In the MM fitting routine, is it just the amplitudes or also lineshapes that are optimized? If the lineshapes are included, where is the gaussianLB_mm saved? Secondly, I saw in the code somewhere that the current SNR calculations use the max height of the spectra instead of Cr (original implementation). But in MRSCont, it indicates that the SNR is wrt Cr. Is this label a remenant of the original implementation or is it infact the SNR of Cr? |
|
Hi John, Sorry for the late reply. This one has slipped my mind. With regards to your questions:
I hope this answers your questions. Thanks for your contribution! Helge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added two lines to op_eccKlose.m that add the eddy current correction to the container. Then I created and annotated osp_exportParams.m in utilities that combines the data fitting parameters and metadata and saves them as a .mat file. I was unable to test with MRSI data, but it works for SVS and multiple files.