-
Notifications
You must be signed in to change notification settings - Fork 44
Prepare v2.3.0 release #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for loading and processing several flavors of Siemens SPECIAL data (including sequences developed by Jamie Near, Masoumeh Dehghani, Layla Riemann). Add a few cosmetic fixes here and there.
Update 3T Siemens SPECIAL basis set. Add small tweaks to the LCModel control file generation for data with water reference.
SPECIAL support
Added a decision tree for the OspreySeg call in the RunOspreyJob function. In case a path to the external segmentation is supplied, but the file doesn't exist yet the OspreySeg will be skipped. This script is used in the compiled Osprey version.
HBCD - external segmentation not finished case - Erik Lee
Added a Siemens 97 ms PRESS basis set for optimized 2HG/Cystat quantification.
Add PRESS 97 ms - Todd Parrish
Add Cystat to the metabolite list for modeling
Added Cystat to the example jobfiles
Integrate Cystat - Todd Parrish
- Add Cystat into the GUI job creator
Integrate Cystat - Todd Parrish
Update the MATALB app
Integrate Cystat - Todd Parrish
Added a round function in various functions to account for non-integer spectralwidth.
[BUG FIX] - Osprey crash for non-integer spectralwidth - McNabb
Fix #438 & bring up to date
[BUG FIX] - Added 7T PE relaxation times for 7T- CWDJ #438
Merge pull request #439 from CWDAVIESJENKINS/develop
[BUG FIX] - Fix issue parsing certain LCModel control file parameters & associated error reporting - #440
Fixes issues related to the GUI crash report on MRSHub (https://forum.mrshub.org/t/error-launching-model-data-and-coregister-in-osprey-gui/859/3). The crash is potentially caused by the pause on error function in MATLAB, as there were some 'yellow' messages after clicking the model and coreg buttons. Those severe errors which were automatically fixed by MATLAB. However, those would still trigger a pause on error if this options is turned on. This is fixed now. Thanks for reporting Lewis Crawford
[BUG FIX] - Osprey GUI crash - Model/Coreg button - Lewis Crawford
Bug fix for crash during HERMES fit. This was related to a list sorting issue with the introduction of cystathionine in the newer basis sets and the all_mets list.
[BUG FIX] - hermes fit crash - fit_sortBasisSet - Kathleen Hupfeld
- Fixed the scaling of the co-edited MM peak at 3 ppm. Scaling issue was related to the on the flight calculation based on the sum spectrum while the initial MMs are calculated with the A sub spectrum. Therefore, this did not occur for MEGA or the older implementation prior to v.2.0.0.
BUG FIX - MM3co scaling - fit functions - Kathleen Hupfeld
Removed duplicate line related to the deletion of .gz files.
[BUG FIX] - duplicate .ni.gz removal - osp_plotCoreg.m - Erik Lee
GUI generated job crashes for MEGA data. This was related to the edit target and include metabolite cells. Additionally, fixed process plots for dcm plots. Release preparation.
[BUG FIX] - Osprey GUI - Crash for MEGA data - Gaelle Doucet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transfer from develop to master for new release.