feat: Add private-leaderboard command #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That looks great, thank you! |
scarvalhojr
reviewed
Dec 12, 2022
| @@ -317,3 +320,103 @@ pub fn read( | |||
| println!("\n{}", from_read(desc.as_bytes(), col_width)); | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn get_private_leaderboard_results( | |||
| args: &Args, | |||
scarvalhojr
reviewed
Dec 12, 2022
| } | ||
|
|
||
| #[derive(Deserialize)] | ||
| struct Member { |
There was a problem hiding this comment.
We could simplify this by implementing TryFrom<&Value> for Member so we only load the fields we need. We could even count the number of stars for each day then rather than when we're writing to the terminal. This would avoid all the fields xxx are never read clippy warnings.
scarvalhojr
reviewed
Dec 12, 2022
| session: &str, | ||
| leaderboard: &str, | ||
| ) -> AocResult<()> { | ||
| let (year, day) = puzzle_year_day(args.year, args.day)?; |
There was a problem hiding this comment.
I think instead of calling puzzle_year_day we need a new function. Something that: 1) unwraps the year if given or returns the latest event year, e.g. let year = args.year.unwrap_or_else(latest_event_year); and 2) returns the last unlocked day for the selected year.
|
I'll merge this as it is and will do some minor changes to make Clippy happy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a private leaderboard command to print the results of a given private leaderboard.
Example output is similar to that on the website - but without colors or headers.