StepwiseNestedSuiteExecution Async Support #2211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cheeseng
commented
Dec 6, 2022
- Adjusted code in StepwiseNestedSuiteExecution to work with async test.
- Updated scaladoc in StepwiseNestedSuiteExecution.scala about passing down None for distributor field, it no longer true.
…down None for distributor field, it no longer true.
| @@ -28,7 +28,7 @@ import collection.mutable.ListBuffer | |||
| * Trait that causes the nested suites of any suite it is mixed into to be run sequentially even if | |||
| * a <a href="Distributor.html"><code>Distributor</code></a> is passed to <code>runNestedSuites</code>. This trait overrides the | |||
| * <code>runNestedSuites</code> method and fowards every parameter passed to it to a superclass invocation | |||
| * of <code>runNestedSuites</code>, except it always passes <code>None</code> for the <code>Distributor</code>. | |||
| * of <code>runNestedSuites</code>, and make the nested suites are run and completed one after one in order. | |||
There was a problem hiding this comment.
I think that something is missing in this sentence, perhaps:
Suggested change
| * of <code>runNestedSuites</code>, and make the nested suites are run and completed one after one in order. | |
| * of <code>runNestedSuites</code>, and make sure the nested suites are run and completed one after one in order. |
There was a problem hiding this comment.
@jespermbyskov You're right, I'll make correction, thanks for catching it! :)
…uiteExecution.scala.
bvenners
approved these changes
Dec 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.