-
Notifications
You must be signed in to change notification settings - Fork 447
This PR addresses [DOC-1330] Allow SEO Customization issue #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 5355d4b The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for scalar-deploy-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This PR fixes #470 issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for taking the time! We can delete the .npmrc and I’ve added two suggestions to improve the comments. What do you think?
.npmrc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fortunately, this is the default already, so we can safely delete the file:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marclave and i had some issues locally on my end yesterday during a coding session. I equally mentioned there's no need to push this file. just forgot to exclude it, my bad.
ogTitle: 'Page title', | ||
ogImage: 'https://example.com/image.png', | ||
twitterCard: 'summary_large_image', | ||
//Add more... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//Add more... | |
/* Full list of parameters: https://github.com/harlan-zw/zhead/blob/main/src/metaFlat.ts */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove .npmrc file
.npmrc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marclave and i had some issues locally on my end yesterday during a coding session. I equally mentioned there's no need to push this file. just forgot to exclude it, my bad.
@hanspagel it should be all good now. Thanks for the suggestions |
@hanspagel how are the latest changes, seems good from my review. We just gotta tidy up the merge conflicts :) |
Oh, sorry. @FotieMConstant any chance you could resolve the conflicts? We’ll get this in ASAP then. |
feat(api-reference): add support for metaData configuration in ApiReference component feat(api-reference): add @unhead/schema and unhead as dependencies in package.json feat(ApiReference.vue): add support for metaData prop and use it to create global head instance and set SEO meta tags chore(types.ts): import MetaFlatInput from '@unhead/schema' feat(types.ts): add metaData property to ReferenceConfiguration type feat(swagger-parser): add vite.config.ts file for configuring Vite build options
Yeah this makes more sense. thanks for the suggesting. Co-authored-by: Hans Pagel <hanspagel@users.noreply.github.com>
…ta tags (title, opengraph data …)
Got it! Thanks for the awesome contribution! :) |
chore(.npmrc): add .npmrc file with auto-install-peers=true
feat(api-reference): add support for metaData configuration in ApiReference component
feat(api-reference): add @unhead/schema and unhead as dependencies in package.json
feat(ApiReference.vue): add support for metaData prop and use it to create global head instance and set SEO meta tags
chore(types.ts): import MetaFlatInput from '@unhead/schema'
feat(types.ts): add metaData property to ReferenceConfiguration type
feat(swagger-parser): add vite.config.ts file for configuring Vite build options