Config-style: control over forcing vs optimization #3961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `runner.optimizer` parameters always force config-style formatting when `newlines.configStyle.xxxSite.prefer` is true, even though they were intended primarily to affect the route search. On the other hand, there could be cases when a user wouldn't enable the `newlines.configStyle.xxxSite.prefer` flag for regular operation (for instance, it makes no sense for `newlines.source=fold/unfold`) but would still be interested in forcing config-style. Therefore, let's add the sibling `xxxSite.forceConfigStyleIfOptimized` flag to decide when to force.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
runner.optimizerparameters always force config-style formatting whennewlines.configStyle.xxxSite.preferis true, even though they were intended primarily to affect the route search.On the other hand, there could be cases when a user wouldn't enable the
newlines.configStyle.xxxSite.preferflag for regular operation (for instance, it makes no sense fornewlines.source=fold/unfold) but would still be interested in forcing config-style.Therefore, let's add the sibling
xxxSite.forceConfigStyleIfOptimizedflag to decide when to force.Helps with #3954.