BestFirstSearch: switch to Long as State key #3942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
State column is unlikely to exceed 24 bits (or 16+ mln bytes), but even in cases when it might, a given token (that is, at a given State depth) cannot conceivably be formatted at two different column values which are a multiple of 2^24 bytes apart. Hence, let's form state key by keeping indentation (just like before) at 8 bits, limiting column to 24 bits and combining with depth in the remaining 32 bits (and this combining is what ensures no hash conflict).
tgodzik
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State column is unlikely to exceed 24 bits (or 16+ mln bytes), but even in cases when it might, a given token (that is, at a given State depth) cannot conceivably be formatted at two different column values which are a multiple of 2^24 bytes apart.
Hence, let's form state key by keeping indentation (just like before) at 8 bits, limiting column to 24 bits and combining with depth in the remaining 32 bits (and this combining is what ensures no hash conflict).