Skip to content

FormatOps: handle .match as select + apply #3500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2023
Merged

FormatOps: handle .match as select + apply #3500

merged 1 commit into from
Mar 16, 2023

Conversation

kitbellew
Copy link
Collaborator

Towards #3489.

@kitbellew kitbellew requested a review from tgodzik March 11, 2023 00:40
@kitbellew
FormatOps: handle .match as select + apply
acaad29 
Modify canStartSelectChain to recognize that while we have generalized
Term.Match as SelectLike when it uses a dot before `match`, along with
Term.Select, in reality a match is also like an apply as it comes with
a block of "arguments" (aka match cases).
@kitbellew
Copy link
Collaborator Author

@tgodzik not sure if this reached your inbox :)

tgodzik
tgodzik approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kitbellew kitbellew merged commit 5e1bd79 into scalameta:master Mar 16, 2023
@kitbellew kitbellew deleted the 3489_4 branch March 16, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kitbellew @tgodzik