Skip to content

Conversation

tgodzik
Copy link
Collaborator

@tgodzik tgodzik commented Sep 17, 2024

It looks like from the parser perspective the only change was binary literals going non experimental in 3.5.0

@tgodzik tgodzik requested a review from kitbellew September 17, 2024 11:44
@tgodzik tgodzik marked this pull request as draft September 17, 2024 12:12
It looks like from the parser perspective the only change was binary literals going non experimental in 3.5.0
@tgodzik tgodzik marked this pull request as ready for review September 17, 2024 13:25
Copy link
Collaborator

@kitbellew kitbellew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question


implicit val Scala3Future: Dialect = Scala3.withAllowUnderscoreAsTypePlaceholder(true)
.withAllowBinaryLiterals(true).withAllowTrackedParameters(true)
.withAllowTrackedParameters(true)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so these tracked parameters are not yet out?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are experimental, so ScalaFuture makes sense here.

@tgodzik tgodzik merged commit ac68e0d into scalameta:main Sep 17, 2024
24 checks passed
@tgodzik tgodzik deleted the add-dialects branch September 17, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants