chore: Add support for Scala 2.13.15 #3974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
af8f720 to
d32245f
Compare
d32245f to
e6d0539
Compare
tgodzik
commented
Sep 23, 2024
| @@ -42,6 +42,6 @@ class Synthetic/*<=example.Synthetic#*/ { | |||
| a/*<=local11*/ <- scala.concurrent.Future/*=>scala.concurrent.Future.*/.successful/*=>scala.concurrent.Future.successful().*/(1) | |||
| b/*<=local12*/ <- scala.concurrent.Future/*=>scala.concurrent.Future.*/.successful/*=>scala.concurrent.Future.successful().*/(2) | |||
| if a/*=>local11*/ </*=>scala.Int#`<`(+3).*/ b/*=>local12*/ | |||
| } yield a/*=>local11*/ | |||
| } yield a/*=>local13*/ | |||
kitbellew
approved these changes
Sep 23, 2024
| if (ScalaVersion.atLeast212_14) body.expected | ||
| else | ||
| // Predef.type etc. was fixed in 2.12.14 | ||
| body.expected.replace("Predef/*=>scala.Predef.*/.type", "Predef.type") |
There was a problem hiding this comment.
is this unrelated? cleanup for 2.12?
There was a problem hiding this comment.
Yep, that's not necessary anymore and I was already cleaning this up.
| @@ -1729,11 +1729,6 @@ Synthetics: | |||
| a, | |||
| b | |||
| ) == (1, 2))}).flatMap[Tuple6[Int, Int, Int, Int, Tuple4[Int, Int, Int, Int], Tuple4[Int, Int, Int, Int]]]({(b) => orig(List((a, b))).withFilter({(check$ifrefutable$1) => orig()}).withFilter({(local7) => orig(( | |||
| a, | |||
There was a problem hiding this comment.
why did this disappear?
There was a problem hiding this comment.
I would assume that some internal desugarings changed, but I honestly think these synthetics are not being used currently by anyone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3973