Skip to content

ScalametaParser: remove modifier validation #3964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2024
Merged

ScalametaParser: remove modifier validation #3964

merged 1 commit into from
Sep 13, 2024

Conversation

kitbellew
Copy link
Collaborator

No description provided.

@kitbellew kitbellew requested a review from tgodzik September 13, 2024 08:02
tgodzik
tgodzik approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I don't think we as a parser should verify it and it might be a problem keeping it up to date always

@kitbellew kitbellew merged commit 5af6e64 into scalameta:main Sep 13, 2024
24 checks passed
@kitbellew kitbellew deleted the 3964 branch September 13, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kitbellew @tgodzik