Skip to content

chore: Add transparent modifier as acceptable for class #3949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2024
Merged

chore: Add transparent modifier as acceptable for class #3949

merged 1 commit into from
Sep 2, 2024

Conversation

tgodzik
Copy link
Collaborator

@tgodzik tgodzik commented Sep 2, 2024 •
edited
Loading

Fixes #3947

I don't think we need to add a dialect for it, since the error isn't really important for parser

@tgodzik tgodzik marked this pull request as ready for review September 2, 2024 14:40
@tgodzik tgodzik requested a review from kitbellew September 2, 2024 14:40
kitbellew
kitbellew approved these changes Sep 2, 2024
View reviewed changes
@kitbellew
Copy link
Collaborator

Fixes #3947

I don't think we need to add a dialect for it, since the error isn't really important for parser

i just checked... apparently, "transparent" is enabled in 3.0 via allowInlineMods flag. not sure if that's ok (don't know when transparent trait was enabled but class only in 3.4, so before that transparent was not even a soft keyword), but ok to deal with it separately.

@tgodzik tgodzik force-pushed the add-transparent-class branch from d380d19 to cc82747 Compare September 2, 2024 15:34
@tgodzik
Copy link
Collaborator Author

tgodzik commented Sep 2, 2024

Fixes #3947
I don't think we need to add a dialect for it, since the error isn't really important for parser

i just checked... apparently, "transparent" is enabled in 3.0 via allowInlineMods flag. not sure if that's ok (don't know when transparent trait was enabled but class only in 3.4, so before that transparent was not even a soft keyword), but ok to deal with it separately.

I could add a separate flag, but I don't really believe this is a big enough change to warrant a separate flag.

@kitbellew kitbellew merged commit 0671568 into scalameta:main Sep 2, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitbellew kitbellew kitbellew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scala 3: transparent class fails to parse
2 participants
@tgodzik @kitbellew