WhitespaceTokenizer: add Granular definition
#3907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 24, 2024
bjaglin
reviewed
Aug 24, 2024
| @@ -19,7 +19,14 @@ object WhitespaceTokenizer { | |||
| def apply(input: Input, dialect: Dialect)(implicit | |||
| options: Option[TokenizerOptions], | |||
| tokens: java.util.Collection[Token] | |||
| ): WhitespaceTokenizer = new Grouping(input, dialect) | |||
| ): WhitespaceTokenizer = | |||
| if (options.forall(_.groupWhitespace)) new Grouping(input, dialect) else new Granular | |||
There was a problem hiding this comment.
I don't mind to force custom options in Scalafix, but shouldn't Granular be the default to preserve the <4.9.8 behavior, at least in the 4.9.x line?
Suggested change
| if (options.forall(_.groupWhitespace)) new Grouping(input, dialect) else new Granular | |
| if (exists(_.groupWhitespace)) new Grouping(input, dialect) else new Granular |
| @@ -4,6 +4,7 @@ import scala.util.DynamicVariable | |||
|
|
|||
| final class TokenizerOptions( | |||
| // options which control how tokens are emitted | |||
| val groupWhitespace: Boolean = true | |||
There was a problem hiding this comment.
same question as above, could it be an opt-in rather than an opt-out?
Suggested change
| val groupWhitespace: Boolean = true | |
| val groupWhitespace: Boolean = false |
Also, let's once again make it default, as before scalameta#3786.
bjaglin
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3786, as a final follow-on.