Tokenizers: don't throw, report errors as a new Invalid token
#3835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invalid token
52c6a88 to
644179d
Compare
tgodzik
requested changes
Jul 24, 2024
| case TRUE => Token.KwTrue(input, dialect, curr.offset) | ||
| case FALSE => Token.KwFalse(input, dialect, curr.offset) | ||
| case NULL => Token.KwNull(input, dialect, curr.offset) | ||
|
|
||
| case INTERPOLATIONID => Token.Interpolation | ||
| .Id(input, dialect, curr.offset, curr.endOffset, curr.strVal) | ||
| case XMLLIT => getXmlPart(curr) | ||
| case XMLLITEND => unreachable | ||
| // case XMLLITEND => unreachable |
There was a problem hiding this comment.
Suggested change
| // case XMLLITEND => unreachable |
and also other below?
There was a problem hiding this comment.
do you mean to remove the lines completely? i kept them to indicate that these particular tokens should not be obtained via this method, and it's not an oversight they are not here.
There was a problem hiding this comment.
Should we just add a comment for all those at the end? It's fine either way
tests/shared/src/test/scala/scala/meta/tests/prettyprinters/PublicSuite.scala
Show resolved
Hide resolved
kitbellew
commented
Jul 24, 2024
tests/shared/src/test/scala/scala/meta/tests/tokenizers/TokenizerSuite.scala
Show resolved
Hide resolved
tgodzik
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses proposal mentioned in #3813.