Skip to content

Conversation

tanishiking
Copy link
Member

@tanishiking tanishiking commented Jul 20, 2022

After updating sbt to 1.7.0, we started to get the following warnings
on startup of sbt.

/Users/tanishiking/src/github.com/tanishiking/metals/build.sbt:57: warning: method sonatypeRepo in class ResolverFunctions is deprecated (since 1.7.0): Use sonatypeOssRepos instead
    resolvers += Resolver.sonatypeRepo("public"),
                          ^
/Users/tanishiking/src/github.com/tanishiking/metals/build.sbt:58: warning: method sonatypeRepo in class ResolverFunctions is deprecated (since 1.7.0): Use sonatypeOssRepos instead
    resolvers += Resolver.sonatypeRepo("snapshot"),
                          ^

As the original PR to sbt/librarymanagement says, sonatyOssRepos add
https://s01.oss.sonatype.org in addition to
https://oss.sonatype.org.
sbt/librarymanagement#393

for more information: https://central.sonatype.org/news/20210223_new-users-on-s01/

After updating sbt to 1.7.0, we started to get the following warnings
on startup of sbt.

```
/Users/tanishiking/src/github.com/tanishiking/metals/build.sbt:57: warning: method sonatypeRepo in class ResolverFunctions is deprecated (since 1.7.0): Use sonatypeOssRepos instead
    resolvers += Resolver.sonatypeRepo("public"),
                          ^
/Users/tanishiking/src/github.com/tanishiking/metals/build.sbt:58: warning: method sonatypeRepo in class ResolverFunctions is deprecated (since 1.7.0): Use sonatypeOssRepos instead
    resolvers += Resolver.sonatypeRepo("snapshot"),
```                          ^

As the original PR to sbt/librarymanagement says, `sonatyOssRepos` add
`https://s01.oss.sonatype.org` in addition to
`https://oss.sonatype.org`.
sbt/librarymanagement#393

for more information: https://central.sonatype.org/news/20210223_new-users-on-s01/
@tanishiking tanishiking merged commit ff787fb into scalameta:main Jul 20, 2022
@tanishiking tanishiking deleted the chore-soanatypeoss branch July 20, 2022 08:14
@kpodsiad
Copy link
Member

kpodsiad commented Jul 21, 2022

@tanishiking
Shouldn't it be Resolver.sonatypeOssRepos("snapshots"),? snapshot -> snapshots?
There is snapshots sonatype repository but not snapshot one

@tgodzik
Copy link
Contributor

tgodzik commented Jul 21, 2022

@tanishiking Shouldn't it be Resolver.sonatypeOssRepos("snapshots"),? snapshot -> snapshots? There is snapshots sonatype repository but not snapshot one

Which means we might not be using it at all 😅

@tanishiking
Copy link
Member Author

Ah, looks like so 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants