Only include delimcc on platforms that support continuations #3975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JD557
commented
Jun 22, 2024
| @@ -45,6 +45,10 @@ object LinktimeInfo { | |||
| ) | |||
| def isWeakReferenceSupported: Boolean = resolved | |||
|
|
|||
| @resolvedAtLinktime() | |||
| def isContinuationsSupported: Boolean = | |||
There was a problem hiding this comment.
Not sure if this should be areContinuationsSupported... but then shouldn't the above check also be areWeakReferencesSupported?
Also, hopefully the list of platforms here is correct. I assumed so because previously only Windows was excluded.
There was a problem hiding this comment.
The plural variant seems more correct, but we won't replace the already existing isWeakReferenceSupported for compatibility reasons. So going with either singular (for keeping convention) or plural (for correctness) is fine with me
WojciechMazur
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3885 by only including delimcc on platforms that support continuations.
In turn, this will only initialize continuations in platforms that support them.