fix[javalib]: Corrections & improvements to Files#find, Files#walk, & Files#walkFileTree methods #3967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Files#walkFileTree methods
|
I am moving this to "draft" whilst I investigate the unit-test failures. One is a Windows JDK compliance which can be factored out as "usual j-random Windows failure" The rest are all in the same test, which passes on macOS & windows. From examining the code for that I believe the underlying code is correct and can be reviewed. |
WojciechMazur
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3744 Fix #3890
This PR introduces a number of improvements to javalib
Files#find,Files#walk, andFiles#walkFileTreemethods.walkFileTreenow detects & reportsFileSystemLoopExceptionfindshould do half the number of attribute lookups. This should increase execution speed.All three methods have been refactored to use common code. This should increase both consistency
and execution speed.
A concerted effort was made to report
IOExceptionandUncheckedIOExceptionin the same conditionsas JVM does. They may still be lingering issues where one of those exceptions is reported by Scala Native
when JVM reports the other.
This code passes the Scala Native
unit-tests.It also passes more extensive semi-automated private tests.