fix [javalib]: Process#waitFor(timeout) now handles large number of nanoseconds #3954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 10, 2024
|
Reviewers, Please see also Issue #3957. I mention this so that you can skip over the obvious defect described. |
WojciechMazur
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix #3944, even though the relationship is not face evident.
This assumes the presence of now merged PR #3950.
javalib
Process#waitFor(timeout)on macOS and recent unix-like operating systems now sets the timeout datastructure it passes to the operating system correctly.
The
tv_nsecnanosecond field is invalid if not between 0 and 999_999_999 (one nano short of a full second) .Otherwise, it is the
errno: 22(EINVAL) reported in the Issue.See Issue #3944 for more details.
This PR also corrects a previously unreported defect when the timeout argument passed to `waitFor(timeout)` is negative. JVM allows negative timeout values. Now SN on macOS and recent unix-like follow the JVM and convert negative timeouts to zero.
waitFor(timeout)on Windows did/does not have this defect.