Skip to content

Conversation

WojciechMazur
Copy link
Contributor

Fixes one of the bugs found in com-lihaoyi/os-lib#274

@WojciechMazur WojciechMazur merged commit 43dc0ed into scala-native:main Jun 4, 2024
@WojciechMazur WojciechMazur deleted the fix/move-broken-symlink branch June 4, 2024 08:20
@LeeTibbert
Copy link
Contributor

@WojciechMazur

If it begins to look like any of the os-lib problems are with Files.walk(), Files.find(), or Files.walkFileTree()
it might be worth knowing that I have been working for the past month on those.

A large number of changes and, I think, improvements. In particular, I have the FileSystemLoopException
believably working in all three.

I am cleaning up the code in order to submit it as a draft PR in a two weeks or so.

I could accelerate that if it looks as if that might fix any of the os-lib issues.

I looked at the logs of the failing os-lib test runs when they were posted and did
not see anything that looked like it was caused by any of those three. However,
if you are looking closer and they begin to look like culprits, I may be able to
save you some time, frustration, & brain power.

@WojciechMazur
Copy link
Contributor Author

@LeeTibbert right now the only problems are with the handling of processes terminated by broken pipes, eg #3944 - seems to be the last blocker before enabling all the remaining tests in os-lib. If you'd like you can take a look at it, you have way more expertise in the current UnixProcessGen2 implementation and domain knowledge in this area. I'll be vacationing till 13.06 so it's not an urgent one

@LeeTibbert
Copy link
Contributor

Wojciech,

You have a kind way of suggesting that I eat my own dog food. 😀

I'll take a run at #3944. The reproducer you posted should make it easier for me to work without
having to set up and figure out a full os-lib build.

I wish you a happy & restorative vacation. You've earned it with all the fixes & versions you
have pushed out recently.

With thanks,

Lee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants