improve [build]: Publish Scala 2.13 artifacts using oldest cross compiled version of Scala 2.13 #3947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cala 2.13 to allow using bigger variarity of Scala versions by the users
sideeffffect
reviewed
Jun 5, 2024
| @@ -46,7 +46,8 @@ jobs: | |||
| java-version: 8 | |||
|
|
|||
| - name: Compile everything | |||
| run: sbt "++3.1.3; Test/compile" | |||
| # Publish 2.13.latest artifacts locally first, these are required by scalalib3 | |||
| run: sbt "scalalib2_13/publishLocal;clean; ++2.13.8; ++3.1.3; Test/compile" | |||
There was a problem hiding this comment.
Isn't ; ++2.13.8; ++3.1.3 the same as ; ++3.1.3? @WojciechMazur
There was a problem hiding this comment.
Not in case of our build - we have dedicated projects split by binary version, eg. scalalib2_13, scalalib3. Each of these has a dedicated crossScalaVersions dependent on the targeted binary version. Because scalalib3/crossScalaVersions does not define any Scala 2 versions the Scala version switch using ++ operator would be ignored in this project, but would be applied in scalalib2_13. This allows us to safety apply ++ operator twice as it would only modify part of the projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3943 - allows the end user to use the minimal Scala 2.13.8 version under the limitations of SIP-51