Skip to content

Fix #2413: Add note to docs for creating sn project in mounted directories #2426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 3, 2021
Merged

Fix #2413: Add note to docs for creating sn project in mounted directories #2426

merged 4 commits into from
Nov 3, 2021

Conversation

ankusharya
Copy link
Contributor

This commit includes

  1. Note, when creating sn project in mounted directory
  2. Add bash scripts to generate docs and add documention on running the bash script in contrib/build.rst

@ankusharya
Fix #2413: Add note to docs for creating sn project in mounted direct…
74f2ab3 
…ory. Add bash script file to generate docs.
@ankusharya ankusharya mentioned this pull request Oct 30, 2021
Closed
WojciechMazur
WojciechMazur reviewed Nov 2, 2021
View reviewed changes
Copy link
Contributor

@WojciechMazur WojciechMazur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, I've left some suggestions on documentation text which in same seemed a bit confusing to me or contained typos

ankusharya and others added 3 commits November 3, 2021 18:46
@ankusharya @WojciechMazur
Update docs/user/sbt.rst as per suggestion
a16e61d 
Co-authored-by: Wojciech Mazur <wojciech.mazur95@gmail.com>
@ankusharya @WojciechMazur
Update docs/user/sbt.rst as per suggestion
0a51574 
Co-authored-by: Wojciech Mazur <wojciech.mazur95@gmail.com>
@ankusharya
Correct grammer and confusing text
0c71574
@ankusharya
Copy link
Contributor Author

@WojciechMazur Hi, I have made corrections as per your suggestion. Please review once.

@ekrich
Copy link
Member

ekrich commented Nov 3, 2021

@ankusharya Congrats on your PR!

@WojciechMazur WojciechMazur merged commit 2fb6592 into scala-native:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WojciechMazur WojciechMazur WojciechMazur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ankusharya @ekrich @WojciechMazur